Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features should return consistent types #1062

Closed
adrien-berchet opened this issue Sep 29, 2022 · 2 comments · Fixed by #1064
Closed

Features should return consistent types #1062

adrien-berchet opened this issue Sep 29, 2022 · 2 comments · Fixed by #1064
Milestone

Comments

@adrien-berchet
Copy link
Member

The NeuroM.features.* functions return inconsistent types. For example, segment_taper_rates returns a list of floats while section_taper_rates returns a list of numpy.float32. This can be annoying to process results (e.g. it's harder to dump the results to JSON strings or stuff like that).
I suggest we make all the types consistent, like casting all the results to built-in Python types.
WDYT @eleftherioszisis @mgeplf ? If you agree I can work on this.

@eleftherioszisis
Copy link
Contributor

Yeah, makes sense to me to have consistent types.

@adrien-berchet
Copy link
Member Author

Will be fixed in v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants