Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in single_burst_ratio, first 2 spikes are ignored #362

Open
anilbey opened this issue Jan 23, 2024 · 0 comments
Open

Bug in single_burst_ratio, first 2 spikes are ignored #362

anilbey opened this issue Jan 23, 2024 · 0 comments

Comments

@anilbey
Copy link
Contributor

anilbey commented Jan 23, 2024

for (size_t i = 1; i < isivalues.size(); i++) {

Here in this loop

  double average = 0.;
  for (size_t i = 1; i < isivalues.size(); i++) {
    average += isivalues[i];
  }

The loop here is ignoring the first ISI. The function returning the ISIs however is LibV1::ISI_values and that is already ignoring the first ISI.

const auto& intFeatures = getFeatures(IntFeatureData, {"ignore_first_ISI"});

As a result first 2 ISIs are removed from the computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant