Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building SDK client fails in CI #203

Closed
demeringo opened this issue Jun 30, 2023 · 2 comments
Closed

Building SDK client fails in CI #203

demeringo opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@demeringo
Copy link
Collaborator

demeringo commented Jun 30, 2023

Bug description

Building SDK client fails in CI

To Reproduce

Confirmed: see output of this action for the dev branch: https://github.com/Boavizta/boaviztapi/actions/workflows/build_client.yml

Expected behavior

Github action should run, needs to be updated to support poetry and/or the makefile that is now the preferred way to build the docker image of the api.

To ease the migration (and continue supporting the prod/main branch before the dev branch is merged to main) I suggest to:

  • create a separate github action that uses poetry + makefile to build SDK (for dev branches)
  • keep existing action (to support existing main branch)
  • remove exixting action after dev has been released.

JSON OUTPUT

Additional context

The github action that builds the client needs to be updated.

The script was build before we decided to use poetry or the makefile to build the docker container (now the standard way to build on the dev branch).

https://github.com/Boavizta/boaviztapi/blob/dev/.github/workflows/build_client.yml

@demeringo demeringo added the bug Something isn't working label Jun 30, 2023
@demeringo demeringo self-assigned this Jul 3, 2023
@da-ekchajzer
Copy link
Collaborator

Merged. I'll close this issue once we test the release workflow on the next release.

@demeringo
Copy link
Collaborator Author

Despite the build fails today (#318 ) I close this issue because it executed OK several time since the merge.

For example: https://github.com/Boavizta/boaviztapi/actions/runs/8270501836/job/22628161236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants