Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the image of the tool in the card view #24

Closed
demeringo opened this issue Oct 18, 2024 · 3 comments · Fixed by #52
Closed

Display the image of the tool in the card view #24

demeringo opened this issue Oct 18, 2024 · 3 comments · Fixed by #52
Labels
enhancement New feature or request

Comments

@demeringo
Copy link
Contributor

demeringo commented Oct 18, 2024

Problem

We want to dipslay an image of each tool in the card view.

Solution

  1. Update the content of the logo (in source data) column to contain only a URL of the image to display
  2. Configure card view to display this image.

Alternatives

Additional context or elements

  • There is also a possibility to use a second image as a logo positioned just before the title. (to be handled separately See Add an icon / small logo in front of the title #51 )
  • We exclude the storage of images in this repository (and prefer to point to existing external images).
@fmomo
Copy link
Contributor

fmomo commented Oct 25, 2024

Even when the content of the logo field is made only of an URL (and not "filename(URL)", the logo is not displayed in the Table view...

@fmomo
Copy link
Contributor

fmomo commented Oct 25, 2024

Why are we excluding image storage in the repository ?

@demeringo
Copy link
Contributor Author

demeringo commented Nov 8, 2024

We exclude storage of images in the git repo in a first step because it means that we have to manage them.

Today there is no user friendly way to upload an image to the repo (without creating a PR using git, and we want to avoid external contributors to do so).

Having an external link allow contributors to use the form to change the target image.

That being sais, it still make sense to manage a copy of image somewhere (to avoid a broken link and also to optimize image size/compress). But I want to depriorize this for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants