Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App crash] When openning edit page #5

Open
pxeemo opened this issue Aug 11, 2024 · 6 comments
Open

[App crash] When openning edit page #5

pxeemo opened this issue Aug 11, 2024 · 6 comments

Comments

@pxeemo
Copy link

pxeemo commented Aug 11, 2024

Everytime I want to edit the data of a song this crash appears:

java.lang.IllegalStateException: Spotify API is null
	at O3.c.b(SourceFile:78)
	at O3.b.q(SourceFile:12)
	at d6.a.k(SourceFile:9)
	at z6.G.run(SourceFile:113)
	at android.os.Handler.handleCallback(Handler.java:959)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8499)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:878)
	Suppressed: E6.f: [D{Cancelling}@fd1951b, Dispatchers.Main.immediate]
@BobbyESP
Copy link
Owner

Thanks for the report. I'll take a look at the fix as fast as possible

@pxeemo
Copy link
Author

pxeemo commented Aug 12, 2024

Thank you. Guess it's kind of a network error on the first launch, and it will fix itself when you establish the connection. But shouldn't it only happen when you tap on download icon to get metadata from Spotify?

@BobbyESP
Copy link
Owner

But shouldn't it only happen when you tap on download icon to get metadata from Spotify?

Indeed, but I made to obtain the Spotify app credentials once you open the edition page so that the user doesn't have to wait for the token to be received.

This has been changed and now the token will be retrieved once the user clicks on the retrieve metadata button

@pxeemo
Copy link
Author

pxeemo commented Aug 15, 2024

It's actually a good idea! The crash can also be handled by displaying it as a snackbar or showing the network error in the retriever bottom sheet if you wanted to be like that.

@BobbyESP
Copy link
Owner

Showing the network error in the retriever bottom sheet if you wanted to be like that.

This was what I've just done. Thanks for the report!

I'll think of using snackbars, but for I don't really like their UI, they are still in the Material 2 implementation

@BobbyESP
Copy link
Owner

Screenrecorder-2024-08-15-18-13-19-132.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants