Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create and fix unit tests to pass with new guess_peaks() #320

Open
FloCiaglia opened this issue Sep 19, 2019 · 2 comments
Open

Create and fix unit tests to pass with new guess_peaks() #320

FloCiaglia opened this issue Sep 19, 2019 · 2 comments
Assignees
@FloCiaglia

Comments

@FloCiaglia
Copy link
Contributor

  • Create new unit tests to check the modified method
  • Fix already existing unit tests to pass with the modified method
@FloCiaglia FloCiaglia added the bug label Sep 19, 2019
@FloCiaglia FloCiaglia self-assigned this Sep 19, 2019
@FloCiaglia FloCiaglia removed the bug label Sep 19, 2019
FloCiaglia added a commit that referenced this issue Oct 2, 2019
@FloCiaglia
changed unit tests to make guess.peasks() pass #320
969f1b2
@Aaron3154518
Copy link
Contributor

Capture all peaks >= 10

@Aaron3154518
Copy link
Contributor

Add check for time location of each peak and FWHM

FloCiaglia added a commit that referenced this issue Oct 23, 2019
@FloCiaglia
#320 working on noise level
2646466
FloCiaglia added a commit that referenced this issue Oct 23, 2019
@FloCiaglia
#320 fixing merge conflict
eeaed34
FloCiaglia added a commit that referenced this issue Nov 6, 2019
@FloCiaglia
modified unit tests #320 and modified gaussianSum() #355
3f17cf4
FloCiaglia added a commit that referenced this issue Nov 7, 2019
@FloCiaglia
made minor changes to unit tests #320
0e569de
FloCiaglia added a commit that referenced this issue Nov 8, 2019
@FloCiaglia
changed unit tests #320
f807bad
cathieO added a commit that referenced this issue Nov 8, 2019
@cathieO
Fixed an issue with troughs being labelled as peaks #320
b3765fb
cathieO added a commit that referenced this issue Nov 8, 2019
@cathieO
#320 sharing code with Flo
84e8f80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FloCiaglia FloCiaglia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aaron3154518 @FloCiaglia