Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid address validation #28

Open
pirinskodxb opened this issue Mar 19, 2024 · 1 comment
Open

Liquid address validation #28

pirinskodxb opened this issue Mar 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@pirinskodxb
Copy link

Traceback (most recent call last):
File "/tmp/test.py", line 36, in
validate_address('GpijgBhNkKDR1wtwqd3x3gPo8XcEWJcSr4', 'liquidv1', 'L-BTC/BTC')
File "/tmp/test.py", line 29, in validate_address
print(addr.address(net))
File "/usr/local/lib/python3.9/dist-packages/embit/script.py", line 25, in address
raise ValueError("This type of script doesn't have address representation")
ValueError: This type of script doesn't have address representation

Testing BoltzClient's validate_address with a test script. I get the same error when attempting a reverse swap.

Seems embit/script.py:from_address() defaults to BTC. Maybe I missed something in my setup or config?

temp fix for me is modifying embit/script.py:
#from .networks import NETWORKS
from embit.liquid.networks import NETWORK

@kilrau
Copy link
Member

kilrau commented Jun 20, 2024

That's an issue with several liquid adress types like legacy addresses, see lnbits/boltz#25 which is an issue of boltz-python and due to embit.

@kilrau kilrau added the bug Something isn't working label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants