Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong results are generating with == operator in case of representation and differentials. #133

Open
rjnrohit opened this issue Apr 20, 2020 · 0 comments · May be fixed by #134
Open

Wrong results are generating with == operator in case of representation and differentials. #133

rjnrohit opened this issue Apr 20, 2020 · 0 comments · May be fixed by #134

Comments

@rjnrohit
Copy link

If we take following points and motions:

auto point1  = make_spherical_representation(23.0*bud::degree,21.0*bud::degree,22.0*meter);
auto point2 = make_spherical_representation(23.0*bud::degree,21.0*bud::degree,22.0*centimeter);
auto motion1  =make_spherical_coslat_differential(21.0*bud::degree,22.0*bud::degree,23.1*meter/second);
auto motion2  =make_spherical_coslat_differential(21.0*bud::degree,22.0*bud::degree,23.1*centimeter/second);
cout << boolalpha << (point1 == point2) << endl; 
cout << boolalpha << (motion1 == motion2) << endl;

we are getting this result:

true
true

But expected:

false
false
@rjnrohit rjnrohit linked a pull request Apr 21, 2020 that will close this issue
Open
@rjnrohit rjnrohit reopened this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

overload ==operator in coordinate systems rjnrohit/astronomy
1 participant
@rjnrohit