Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Change FreezeLog to a "pure" time lock specification #435

Open
YoshihitoAso opened this issue Mar 29, 2024 · 0 comments
Open

[FEATURE] Change FreezeLog to a "pure" time lock specification #435

YoshihitoAso opened this issue Mar 29, 2024 · 0 comments
Assignees
Labels
specification change Specification changes to existing contracts

Comments

@YoshihitoAso
Copy link
Member

Is your feature request related to a problem? Please describe.

The current FreezeLog contract specification control the update so that it cannot be updated once a specified number of blocks has arrived, rather than at a specific time.

However, counting up the number of blocks is sensitive to the operating status of the blockchain.
Therefore, I would like to lock purely by time rather than by block number.

Also, by locking by time, there will be no problem even if emptyBlockPeriod is introduced in the ibet network in the future.

Describe the solution you'd like

I'm thinking of using block.timestamp.
In the consortium chain, the block.timestamp setting value is trustworthy, so we believe that there is no problem in using it.

@YoshihitoAso YoshihitoAso added the enhancement New feature or request label Mar 29, 2024
@YoshihitoAso YoshihitoAso self-assigned this Mar 29, 2024
@YoshihitoAso YoshihitoAso added specification change Specification changes to existing contracts and removed enhancement New feature or request labels Mar 29, 2024
@YoshihitoAso YoshihitoAso moved this to Backlog in ibet-Network v2.4 Mar 29, 2024
@YoshihitoAso YoshihitoAso moved this from Backlog to Ready in ibet-Network v2.4 Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specification change Specification changes to existing contracts
Projects
None yet
Development

No branches or pull requests

1 participant