Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shuffling of colData rows if SingleCellExperiment is used #454

Closed
zktuong opened this issue Dec 10, 2024 · 1 comment · Fixed by #455
Closed

shuffling of colData rows if SingleCellExperiment is used #454

zktuong opened this issue Dec 10, 2024 · 1 comment · Fixed by #455

Comments

@zktuong
Copy link
Contributor

zktuong commented Dec 10, 2024

Hey Nick,

seems like this is a bug here:

https://github.com/ncborcherding/scRepertoire/blob/08e80abcaf1e45adbc59428788ca1c32904c9644/R/combineExpression.R#L206-L208

where the order of this two vectors are not matching rownames(colData(sc.data)) <- rownames. Simply stopping at 206 should work?
@zktuong zktuong mentioned this issue Dec 10, 2024
Merged
@zktuong
Copy link
Contributor Author

zktuong commented Dec 10, 2024

actually the real issue is here:

https://github.com/ncborcherding/scRepertoire/blob/08e80abcaf1e45adbc59428788ca1c32904c9644/R/combineExpression.R#L203

where the colData itself is shuffled.

@zktuong zktuong mentioned this issue Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix shuffling of cell barcodes in SingleCellExperiment object tuonglab/scRepertoire
1 participant
@zktuong