Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support constraint checking for :id #6

Open
kirega opened this issue Mar 27, 2024 · 2 comments
Open

Support constraint checking for :id #6

kirega opened this issue Mar 27, 2024 · 2 comments

Comments

@kirega
Copy link
Contributor

kirega commented Mar 27, 2024

Firstly, I must express my appreciation for the wonderful work that you have done in creating this library. It seamlessly solves an otherwise mundane task.

To keep the lib growing, I suggest adding support for validation checking for type :id, I think it's the most common way that people type their id fields. At present to have this lib added to an existing project is not easy without necessitating breaking changes.
There may be underlying decisions as to why the id is not presently supported, and I am happy to hear from you the reasoning behind the choice.
I am happy to raise a PR with the proposed changes.
Again, awesome work. Looking forward to hearing from you.

@DReigada
Copy link
Contributor

DReigada commented Apr 8, 2024

Thank you for the input @kirega! PRs are totally welcome
What would you see as the check for an :id type?

@kirega
Copy link
Contributor Author

kirega commented Apr 11, 2024

What i have mostly used the id type for is for uuid checks and length as well, in a way the same checks that are available for string types can be used, alongside the format ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants