Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it make sense to consolidate CEXE_sources cEXE_sources, f90EXE_sources, etc. into just one? #20

Open
WeiqunZhang opened this issue Dec 2, 2016 · 5 comments

Comments

@WeiqunZhang
Copy link
Member

Like to hear people's opinion.

There are 8 types of files in BoxLib's build system.

CEXE_sources for C++ source files with .cpp extension.
CEXE_headers for C++ headers with .h or .H extension.
cEXE_sources for C source files with .c extension.
cEXE_headers for C headers with .h or .H extension.
f90EXE_sources for free format Fortran sources with .f90 extension.
F90EXE_sources for free format Fortran sources with .F90 extension requiring preprocessing.
fEXE_sources for fixed format Fortran sources with .f extension.
FEXE_sources for fixed format Fortran sources with .F extension requiring preprocessing.

Do we really need all these types? Can we get away by consolidate them into just one say boxlibEXE_sources and then use file extensions to figure out the types.

@maxpkatz
Copy link
Member

maxpkatz commented Dec 2, 2016

I think it would be nice if the codes could just specify all the sources into one boxlibEXE_sources variable, but we may want to retain those other file types at least for now, until we are confident that there is no use for them.

@zingale
Copy link
Member

zingale commented Dec 2, 2016

I think this is a good idea. We can use wildcards to extract the files by type as needed

@WeiqunZhang
Copy link
Member Author

Sure, we will of course keep it backward compatible.

@WeiqunZhang
Copy link
Member Author

Want to add that I have seen multiple times people scratch their head trying to figure out what went wrong. It turned out it was just a typo in case (e.g., f90exe_sources instead of f90EXE_sources). So we could also make boxlibEXE_sources case insensitive.

I will leave this issue open for a week. If I don't hear any objections, I will do it.

@maxpkatz
Copy link
Member

maxpkatz commented Dec 2, 2016

+1 for case insensitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants