Skip to content

Commit dea8d61

Browse files
authored
Merge pull request #105 from BrainLesion/103-bug-weird-installation-error-when-using-a-python-312-conda-environment
103 bug weird installation error when using a python 312 conda environment
2 parents eea7565 + 4421dd4 commit dea8d61

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
python-version: ["3.10", "3.11"]
19+
python-version: ["3.10", "3.11", "3.12"]
2020

2121
steps:
2222
- uses: actions/checkout@v3

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,12 @@ Please credit the authors by citing their work.
115115
### Registration
116116
We currently provide support for [ANTs](https://github.com/ANTsX/ANTs) (default), [Niftyreg](https://github.com/KCL-BMEIS/niftyreg) (Linux), eReg (experimental)
117117

118+
> [!NOTE]
119+
> For python `3.13` the installation can currently fail with the error `Failed to build antspyx`.
120+
> This usually means that there is no pre-built wheel for the package and it has to be build locally.
121+
> This will require cmake (install e.g. with `pip install cmake`) and quite some time.
122+
> Rerunning the installation with cmake installed should fix the error.
123+
118124
### Atlas Reference
119125
We provide the SRI-24 atlas from this [publication](https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2915788/).
120126
However, custom atlases in NIfTI format are supported.

pyproject.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ exclude = [
1414
]
1515

1616
name = "brainles_preprocessing"
17-
version = "0.0.0" # will be overwritten by poetry-dynamic-versioning but needs to be set
17+
version = "0.0.0.dev" # will be overwritten by poetry-dynamic-versioning but needs to be set
1818
description = "Tool for preprocessing tasks in biomedical imaging, with a focus on (but not limited to) multi-modal brain MRI"
1919
license = "Apache-2.0"
2020

@@ -59,7 +59,7 @@ numpy = "^1.23.0"
5959
antspyx = "^0.4.2"
6060

6161
# hd-bet reqs
62-
brainles_hd_bet = ">=0.0.8"
62+
brainles_hd_bet = ">=0.0.10"
6363

6464
# utils
6565
tqdm = "^4.64.1"
@@ -75,7 +75,7 @@ all = ["ereg"]
7575
ereg = ["ereg"]
7676

7777

78-
[tool.poetry.dev-dependencies]
78+
[tool.poetry.group.dev.dependencies]
7979
pytest = ">=8.1.1"
8080

8181
[tool.poetry.group.docs]

tests/test_registrators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ def get_method_and_extension(self):
1515
return "ants", "mat"
1616

1717

18-
class TestNiftyRegRegistratorRegistrator(RegistratorBase, unittest.TestCase):
18+
class TestNiftyRegRegistrator(RegistratorBase, unittest.TestCase):
1919
def get_registrator(self):
2020
return NiftyRegRegistrator()
2121

2222
def get_method_and_extension(self):
2323
return "niftyreg", "txt"
2424

2525

26-
class TestEregRegistratorRegistrator(RegistratorBase, unittest.TestCase):
26+
class TestEregRegistrator(RegistratorBase, unittest.TestCase):
2727
def get_registrator(self):
2828
return eRegRegistrator()
2929

0 commit comments

Comments
 (0)