Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that multiple investment years are interpreted properly in inputs/outputs #115

Open
danielolsen opened this issue Jun 29, 2021 · 1 comment

Comments

@danielolsen
Copy link
Contributor

danielolsen commented Jun 29, 2021

Currently, when interpreting the values of build decision variables, we are assuming that they are cumulative. I.e., if investment years are x and y where x < y, then new_capacity(x) <= new_capacity(y). Therefore, for each investment year, we can create a grid representing the capacities in that year as existing_capacity + new_capacity(x) or existing_capacity + new_capacity(y). See #97, #104 for more context.

However, if investments are not cumulative, then there is no relationship new_capacity(x) <= new_capacity(y) and the grid capacities in each investment year need to be interpreted instead as existing_capacity + sum(i <= x, new_capacity(i).

The primary thing I think needs to be checked is the interpretation of the outputs, but during testing of this functionality we may find that there is additional work needed for the inputs as well, particularly relating to the timepoints parameter of switchwrapper.prepare.prepare_inputs and the information provided by the user in the switchwrapper.grid_to_switch.get_inv_periods function.

@YifanLi86
Copy link
Contributor

YifanLi86 commented Jun 29, 2021

@danielolsen Good catch. From the manual and codes it looks very unlikely to be cumulative, and need to be interpreted as existing_capacity + sum(i <= x, new_capacity(i).

"BuildGen[g,p] Amount of capacity built (added) in project g in period p;"
"BuildTx[l,p] Transfer capability added in corridor l during period p (MW);"

I have not done any multi-year test to verify, but definitely need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants