Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build mock objects #51

Closed
rouille opened this issue May 17, 2021 · 9 comments
Closed

Build mock objects #51

rouille opened this issue May 17, 2021 · 9 comments
Assignees
Labels

Comments

@rouille
Copy link
Collaborator

rouille commented May 17, 2021

We need to instantiate a MockGrid and MockScenario objects to hopefully used modules in PostREISE

@danielolsen
Copy link
Contributor

If we get the Grid from #49, and the time-series outputs from #50, then is there anything else we need to be able to make a MockScenario? Or is the remaining work to create a user-facing function that does it all, starting from a folder of outputs?

@rouille
Copy link
Collaborator Author

rouille commented May 27, 2021

If we get the Grid from #49, and the time-series outputs from #50, then is there anything else we need to be able to make a MockScenario? Or is the remaining work to create a user-facing function that does it all, starting from a folder of outputs?

I don't think so. We might need to update our mock objects. They probably don't handle profiles

@danielolsen
Copy link
Contributor

MockScenario can handle profiles just fine, via MockAnalyze: https://github.com/Breakthrough-Energy/PowerSimData/blob/develop/powersimdata/tests/mock_analyze.py#L25

@BainanXia
Copy link
Collaborator

BainanXia commented May 27, 2021

If we get the Grid from #49, and the time-series outputs from #50, then is there anything else we need to be able to make a MockScenario? Or is the remaining work to create a user-facing function that does it all, starting from a folder of outputs?

I don't think so. We might need to update our mock objects. They probably don't handle profiles

Based on my most recent experience using mock objects, they could take mock profiles in the current structure. To be specific, mock scenario could take mock profiles and mock grid attributes. Example use case here.

@rouille
Copy link
Collaborator Author

rouille commented May 28, 2021

Is MockGrid up to date? Not sure it has the model_immutables attribute?

@rouille rouille added v0.3 v0.2 and removed v0.3 labels May 28, 2021
@danielolsen
Copy link
Contributor

We will need to re-process the time-series inputs so that they have the proper index and columns for the Scenario object to use when calculating things like curtailment.

@danielolsen
Copy link
Contributor

danielolsen commented Jun 14, 2021

Here's the status of everything I think we need for a 'full' MockScenario object representing the Switch solution:

EDIT: Besides what we are already saving in the Switch project folder, it seems that we also need as inputs:

  • the temporal mapping file used to create time-series inputs to Switch
  • The timepoints.csv file used to create time-series inputs to Switch

If we begin to save these files in the folder when we generate the Switch inputs (i.e. within profiles_to_switch, we save the timepoints and timestamp_to_timepoints input parameters), then I think the Switch project folder should contain all the necessary information to build a MockScenario object (excluding duals and storage time series for now), and we should be able to only ask the user 'which folder should I look into for all of the files that I need?'.

@danielolsen
Copy link
Contributor

As discussed elsewhere, there may be two different use cases that the user wants. Either:

  • the user wants to analyze the MockScenario as Switch saw it (i.e. temporal reduction on the input profiles)
  • the user wants to use the MockScenario to perform a full time-domain production cost modeling analysis (i.e. as we would do if we created a fresh Scenario using a ChangeTable; the input profiles are not reduced)

The former is implemented via #107, the latter seems to be desired by @YifanLi86. I think this could be an option that the user selects from the main user-facing function when they pass the Switch project folder, once we have backend logic for the latter feature.

@danielolsen
Copy link
Contributor

Closed via #109 and #111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants