Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font setting is not using the phone's selected font for articles #15

Open
sinfullad opened this issue Nov 4, 2022 · 5 comments
Open
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed ui

Comments

@sinfullad
Copy link

  • [✓] I use the latest GitHub release of the app.

Describe the bug
Font setting is not using the font of the phone to show the article, but the default Android font.

Screenshots
Screenshot_20221104_075322.jpg
Screenshot_20221104_074319_Settings.jpg

Smartphone (please complete the following information):

  • Device: [Samsung A33 5G]
  • OS: [Android 12, OneUI 4.1]

Additional context
I'm using the latest debug build that improved the setting page.

@sinfullad sinfullad added the enhancement New feature or request label Nov 4, 2022
@BrightDV
Copy link
Owner

BrightDV commented Nov 4, 2022

Sadly, this is a limitation on Flutter's side. It uses the Roboto font by default (which is often used on Android devices), not the system's font.

Related: flutter/flutter#48381.

@sinfullad
Copy link
Author

sinfullad commented Nov 4, 2022

Sadly, this is a limitation on Flutter's side. It uses the Roboto font by default (which is often used on Android devices), not the system's font.

Related: flutter/flutter#48381.

That's a shame, I don't know much about Flutter, it can't detect what font the system is using nor the type of fonts that the phone has in storage?

Maybe you can add a list of fonts to customize instead?

After looking around a bit, maybe you can add old fonts that F1 used to use for their TV graphics like:
Benton Sans 2015-2017
DIN 1451 from 2010-2014
Frutiger 55 from 2004-2009
Futura from 1994-2003

Could be potential idea for themes too if you want to

@BrightDV
Copy link
Owner

BrightDV commented Nov 4, 2022

That's a shame, I don't know much about Flutter, it can't detect what font the system is using nor the type of fonts that the phone has in storage?

I did some research and found a workaround to add it but it is not very convenient and it needs a lot of work to implement it.

Maybe you can add a list of fonts to customize instead?

After looking around a bit, maybe you can add old fonts that F1 used to use for their TV graphics like:
Benton Sans 2015-2017
DIN 1451 from 2010-2014
Frutiger 55 from 2004-2009
Futura from 1994-2003

Could be potential idea for themes too if you

I don't think this is a needed feature right now given the amount of time required to add it, and now I plan to add more widgets of the articles and improve the hall of fame.
Maybe I could add some retro themes with the old fonts, I will think about it...
Also, where did you find these fonts?

@sinfullad
Copy link
Author

sinfullad commented Nov 4, 2022

Maybe I could add some retro themes with the old fonts, I will think about it...
Also, where did you find these fonts?

This is the best I can find with some quick searches 😅
https://gprejects.com/forum/viewtopic.php?f=4&t=6159
https://github.com/ktomov/old-fonts-in-f1

@BrightDV BrightDV added the ui label Nov 10, 2022
@BrightDV BrightDV added the help wanted Extra attention is needed label Jan 17, 2023
@BrightDV
Copy link
Owner

Finally, I added the Titilium-Web font (which is used by the official website in the articles)(382234f).
So now, you can choose between Android's default (Roboto), the official one and Titilium.
If needed, I can also add some older font, however, this setting is applied for the articles' font to improve readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ui
Projects
None yet
Development

No branches or pull requests

2 participants