Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit block #249

Closed
JohnCoene opened this issue Feb 1, 2024 · 2 comments
Closed

Submit block #249

JohnCoene opened this issue Feb 1, 2024 · 2 comments
Labels
open discussion Ongoing discussions, not ready to start

Comments

@JohnCoene
Copy link
Member

@DivadNojnarg the submit block is pretty neat (!), only needs the submit_block class.

For #239 I use it to submit the code for the block, is there way to have it such that it "submits on load," e.g.: the default expression is data it should be valid but we have manually hit submit (see below).

image

I might be missing something

@JohnCoene JohnCoene added the open discussion Ongoing discussions, not ready to start label Feb 1, 2024
@DivadNojnarg
Copy link
Collaborator

We are actually thinking to avoid passing that as a class but more as a block parameter. I am not sure you're missing something, there should be an autoclick feature which can be enabled or not on load but that's not implemented.

@nbenn
Copy link
Collaborator

nbenn commented Feb 8, 2024

@JohnCoene @DivadNojnarg changing how the submit functionality is implemented is being tracked in #162. The code block now lives in BristolMyersSquibb/blockr.extra#7. I'll therefore close here. Please re-open if I'm missing the point here.

Regarding the submit-on-load issue, I'm adding a note to #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open discussion Ongoing discussions, not ready to start
Projects
None yet
Development

No branches or pull requests

3 participants