Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of none leap year time types (BODCDMSYS-3689) #441

Open
jpolton opened this issue May 23, 2022 · 4 comments · May be fixed by #480
Open

Handling of none leap year time types (BODCDMSYS-3689) #441

jpolton opened this issue May 23, 2022 · 4 comments · May be fixed by #480
Assignees
@lukegorman @roje-bodc

Comments

@jpolton
Copy link
Collaborator

jpolton commented May 23, 2022

Some model output may not contain leap year days. Xarray seems to handle this data differently. A lot of routines should still work but any time manipulation might see problems.

An option for handling this would be to write a time_stretch() routine which is able to stretch this data onto a full year's calendar.
@thogar-computer thogar-computer moved this to Todo in COAsT_dev May 23, 2022
@thogar-computer
Copy link
Member

@jpolton to update the description
@katavouta to provide an example of code that does this

@katavouta
Copy link
Collaborator

katavouta commented Jun 10, 2022 •
edited
Loading

I sent a very simplistic python example to @thogar-computer (that includes two methods for transforming from 360 calendar year to 365/366 calendar year).

@roje-bodc roje-bodc moved this from BODC - Todo to BODC - In Progress in COAsT_dev Jun 21, 2022
@roje-bodc roje-bodc self-assigned this Jun 21, 2022
@lukegorman
Copy link
Contributor

lukegorman commented Jun 24, 2022 •
edited
Loading

so we want to interpolate the date time dimension instead of just date time -> index (1,2,3,4...)?

@lukegorman
Copy link
Contributor

lukegorman commented Jun 24, 2022 •
edited
Loading

do you want an interpolation or an extrapolation???

@roje-bodc has tried an extrapolation but the data does not look good for some reason

@lukegorman lukegorman self-assigned this Jun 27, 2022
@roje-bodc roje-bodc linked a pull request Jun 30, 2022 that will close this issue
Feature/leap years #480
Open
@jpolton jpolton moved this from BODC - In Progress to BODC - Todo in COAsT_dev Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukegorman lukegorman

@roje-bodc roje-bodc

Labels
None yet
Projects
COAsT_dev
Status: BODC - Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/leap years British-Oceanographic-Data-Centre/COAsT
5 participants
@lukegorman @thogar-computer @jpolton @katavouta @roje-bodc