Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: hydrographic diagnostics #535

Open
jpolton opened this issue Sep 8, 2022 · 0 comments · May be fixed by #540
Open

WIP: hydrographic diagnostics #535

jpolton opened this issue Sep 8, 2022 · 0 comments · May be fixed by #540
Assignees
@jpolton @jasontempestholt

Comments

@jpolton
Copy link
Collaborator

jpolton commented Sep 8, 2022 •
edited
Loading

New, but incomplete, hydrographic diagnostics classes were pulled from SE-NEMO in a new branch: feature/535_stratification_diag
for continued development

In particular file diagnostics/annual_hydrographic_climatology.py and diagnostics/hydrographic.py are not unit tested so we can't ensure it is maintained.

Propose name changes: gridded_monthly_hydrographic_climatology.py and profile_hydrographic_analysis.py
Various method edits are also made in keeping with COAsT conventions.
@jpolton jpolton linked a pull request Sep 8, 2022 that will close this issue
WIP: Hydrographic Diagnostics need unit_tests #537
Closed
@jpolton jpolton removed a link to a pull request Sep 8, 2022
WIP: Hydrographic Diagnostics need unit_tests #537
Closed
@jpolton jpolton linked a pull request Sep 8, 2022 that will close this issue
Move classes without unit test from develop #539
Merged
@jpolton jpolton removed a link to a pull request Sep 8, 2022
Move classes without unit test from develop #539
Merged
This was linked to pull requests Sep 8, 2022
WIP: Hydrographic Diagnostics need unit_tests #537
Closed
Feature/535 stratification diag #540
Draft
@jpolton jpolton changed the title Missing unit_tests diagnostics/annual_hydrographic_climatology.py WIP: hydrographic diagnostics Sep 8, 2022
@jpolton jpolton self-assigned this Nov 17, 2022
@jpolton jpolton moved this from MSM - todo to MSM - in progress in COAsT_dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpolton jpolton

@jasontempestholt jasontempestholt

Labels
None yet
Projects
COAsT_dev
Status: MSM - in progress
Milestone
No milestone
2 participants
@jpolton @jasontempestholt