Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy notebooks #602

Closed
jpolton opened this issue Nov 24, 2022 · 9 comments · Fixed by #634
Closed

Tidy notebooks #602

jpolton opened this issue Nov 24, 2022 · 9 comments · Fixed by #634
Assignees

Comments

@jpolton
Copy link
Collaborator

jpolton commented Nov 24, 2022

example_scripts folders are a bit messy. It looks like some of it is not getting push to the docsy site and should be reviewed. Should it be removed altogether or added.

@jpolton jpolton changed the title Tidy docsy notebooks Tidy notebooks Nov 24, 2022
@thogar-computer
Copy link
Member

everything within the runnable folder should be runnable, everything else needs to be looked at and see if it is used, if not then it needs to be deleted.

@roje-bodc
Copy link
Collaborator

roje-bodc commented Oct 31, 2023

Note that the push to the docsy site has been broken for a long time.

I have fixed this push as part of ticket: #551

The latest notebook git actions on the coast site repo have all passed.

@roje-bodc roje-bodc moved this from BODC - Todo to BODC - In Progress in COAsT_dev Oct 31, 2023
@roje-bodc roje-bodc self-assigned this Oct 31, 2023
@roje-bodc
Copy link
Collaborator

Also as the conversion to markdown passed, this means that all of the notebooks in the runnable notebooks folder are runnable. The notebooks are executed as part of the conversion process.

@roje-bodc
Copy link
Collaborator

roje-bodc commented Nov 1, 2023

@jpolton Out of the entire example scripts folder, these are the files that aren't currently mentioned on the docsy site:

EXAMPLE_SCRIPTS/
│   indexed_tutorial.py
│   README
│   stratification_pycnocline_diagnostics.py
│   __init__.py
│
├───configuration_gallery/
│       anchor_plots_of_nsea_wvel.py
│       blz_example_plot.py
│       seasia_dic_example_plot.py
│
└───profile_validation/
        1._analysis_preprocess_en4.ipynb
        2._analysis_extract_and_compare.ipynb
        3._analysis_extract_and_compare_single_process_tutorial.ipynb
        4._analysis_mask_means_tutorial.ipynb
        5._analysis_average_into_grid_boxes.ipynb
        analysis_extract_and_compare.py
        plot_validation_gridded_data.py
        plot_validation_gridded_data_tutorial.ipynb
        plot_validation_mask_means.ipynb
        plot_validation_mask_means.py
        plot_validation_surface_errors.ipynb
        plot_validation_surface_errors.py

Is there anything here you'd think should be removed completely?

The profile validation files seem well laid out, so I'd think that the best thing to do for these is to have a section on the docsy site explaining what they are?

Note that a lot of these scripts refer to random data files on the livljobs servers under different personal linux area's.. so I'm not sure how useful those are if the user isn't able to access them.

@roje-bodc
Copy link
Collaborator

@jpolton I've added my suggestions beside each file here:


EXAMPLE_SCRIPTS/
│   indexed_tutorial.py	(Delete or convert to a notebook?)
│   README (Keep)
│   stratification_pycnocline_diagnostics.py (Delete this? There seems to be a similarly title notebook 
						'notebook_tutorials\runnable_notebooks\gridded\pycnocline_tutorial.ipynb' )
│   __init__.py	(Delete this? I don't think anyone is using this directory as a package.)
│
├───configuration_gallery/
│       anchor_plots_of_nsea_wvel.py (Convert this to a notebook?)
│       blz_example_plot.py (Convert this to a notebook?)
│       seasia_dic_example_plot.py (Convert this to a notebook?)
│
└───profile_validation/ (Not sure what these do but they are well laid out. Maybe just need a section on the docsy explaining what they are??
				Might need a opinion here to see whether these are useful or not )
        1._analysis_preprocess_en4.ipynb
        2._analysis_extract_and_compare.ipynb
        3._analysis_extract_and_compare_single_process_tutorial.ipynb
        4._analysis_mask_means_tutorial.ipynb
        5._analysis_average_into_grid_boxes.ipynb
        analysis_extract_and_compare.py
        plot_validation_gridded_data.py
        plot_validation_gridded_data_tutorial.ipynb
        plot_validation_mask_means.ipynb
        plot_validation_mask_means.py
        plot_validation_surface_errors.ipynb
        plot_validation_surface_errors.py

@jpolton
Copy link
Collaborator Author

jpolton commented Nov 2, 2023

Profile_validation/ is all copied into Runnable Section "Introduction to profile class". So can be removed.

configuration_gallery/ is not worth keeping, so can be removed.

stratification_pycnocline_diagnostics.py - delete

README - update (keep only 1st paragraph)

indexed_tutorial.py - Keep? This is a bit of a placeholder for stubs we haven't expanded? To discuss

@roje-bodc roje-bodc linked a pull request Nov 2, 2023 that will close this issue
18 tasks
@roje-bodc
Copy link
Collaborator

I've made the above changes and they are in a pull request:
#634

I've also removed reference to the configuration gallery folder in the coast site:
British-Oceanographic-Data-Centre/COAsT-site#94

@roje-bodc
Copy link
Collaborator

roje-bodc commented Nov 2, 2023

@jpolton I've re-added the configuration gallery files that we want to keep (the ones referenced in the docsy site.) So the Pull request #634 is now okay to review.

(Not sure why is says the Amm15 file is blank, as it does exist on the branch. So just ignore that part. I think github got a bit confused since I re-added the file after deleting it.)

@github-project-automation github-project-automation bot moved this from BODC - In Progress to Done in COAsT_dev Nov 2, 2023
@roje-bodc roje-bodc moved this from Done to Merged to Develop in COAsT_dev Nov 2, 2023
@roje-bodc
Copy link
Collaborator

This has now been merged to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged to Develop
Development

Successfully merging a pull request may close this issue.

3 participants