-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy notebooks #602
Comments
everything within the runnable folder should be runnable, everything else needs to be looked at and see if it is used, if not then it needs to be deleted. |
Note that the push to the docsy site has been broken for a long time. I have fixed this push as part of ticket: #551 The latest notebook git actions on the coast site repo have all passed. |
Also as the conversion to markdown passed, this means that all of the notebooks in the runnable notebooks folder are runnable. The notebooks are executed as part of the conversion process. |
@jpolton Out of the entire example scripts folder, these are the files that aren't currently mentioned on the docsy site: EXAMPLE_SCRIPTS/
│ indexed_tutorial.py
│ README
│ stratification_pycnocline_diagnostics.py
│ __init__.py
│
├───configuration_gallery/
│ anchor_plots_of_nsea_wvel.py
│ blz_example_plot.py
│ seasia_dic_example_plot.py
│
└───profile_validation/
1._analysis_preprocess_en4.ipynb
2._analysis_extract_and_compare.ipynb
3._analysis_extract_and_compare_single_process_tutorial.ipynb
4._analysis_mask_means_tutorial.ipynb
5._analysis_average_into_grid_boxes.ipynb
analysis_extract_and_compare.py
plot_validation_gridded_data.py
plot_validation_gridded_data_tutorial.ipynb
plot_validation_mask_means.ipynb
plot_validation_mask_means.py
plot_validation_surface_errors.ipynb
plot_validation_surface_errors.py Is there anything here you'd think should be removed completely? The profile validation files seem well laid out, so I'd think that the best thing to do for these is to have a section on the docsy site explaining what they are? Note that a lot of these scripts refer to random data files on the livljobs servers under different personal linux area's.. so I'm not sure how useful those are if the user isn't able to access them. |
@jpolton I've added my suggestions beside each file here:
|
README - update (keep only 1st paragraph)
|
I've made the above changes and they are in a pull request: I've also removed reference to the configuration gallery folder in the coast site: |
@jpolton I've re-added the configuration gallery files that we want to keep (the ones referenced in the docsy site.) So the Pull request #634 is now okay to review. (Not sure why is says the Amm15 file is blank, as it does exist on the branch. So just ignore that part. I think github got a bit confused since I re-added the file after deleting it.) |
This has now been merged to develop |
example_scripts folders are a bit messy. It looks like some of it is not getting push to the docsy site and should be reviewed. Should it be removed altogether or added.
The text was updated successfully, but these errors were encountered: