Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] construct_density() with potential density #611

Open
1 task done
b-barton opened this issue Jan 30, 2023 · 0 comments
Open
1 task done

[BUG] construct_density() with potential density #611

b-barton opened this issue Jan 30, 2023 · 0 comments

Comments

@b-barton
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When using construct_density(eos='EOS10', pot_dens=True), absolute salinity is calculated with surface referenced pressure (pressure_absolute = 0).

Expected Behavior

The absolute salinity should be calculated with in situ pressure as is done with pot_dens=False. The only use of surface reference pressure should be in calculating rho. The gsw.rho function requres absolute salinity not surface referenced absolute salinity.

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant