Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIDS - Computation of SliceTiming #124

Open
gjpcbecq opened this issue Jul 28, 2023 · 2 comments
Open

BIDS - Computation of SliceTiming #124

gjpcbecq opened this issue Jul 28, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gjpcbecq
Copy link

Description of be the bug
The SliceTiming computation in version 0.3.8 of brkraw seems to give a wrong result.

In /lib/reference.py the formulation is:

         SliceTiming                    = dict(TR           = 'VisuAcqRepetitionTime',
                                               Num_of_Slice = 'VisuCoreFrameCount',
                                               Order        = 'ACQ_obj_order',
                                               Equation     = 'np.linspace(0, TR/1000, Num_of_Slice + 1)[Order]'),

For example, I have a fMRI with 3600 volumes, a TR of 0.5 s, each volume is 64 x 64 x 9, with volume acquisition over the 9 slices.

The bruker parameters are

for visu_pars:

VisuCoreFrameCount            :  32400
VisuAcqRepetitionTime         :  500

for acqp:

NR                            :  3600
ACQ_obj_order                 :  [0, 2, 4, 6, 8, 1, 3, 5, 7]

applying print_bids to the recording gives:

[0.0, 3.08641975308642e-05, 6.17283950617284e-05, 9.25925925925926e-05, 0.0001234567901234568, 1.54320987654321e-05, 4.62962962962963e-05, 7.716049382716049e-05, 0.0001080246913580247]

It seems that you divide the TR by the total number of acquisitions ($32400 = 3600 \times 9$) and not the number of acquisition for one volume.

Do you agree with that or do I am wrong ?

@araikes
Copy link

araikes commented Aug 3, 2023

You're correct @gjpcbecq, the slice timing definition should be the timing of a slice acquisition within a TR.

@dvm-shlee
Copy link
Member

Thank you for your input, this will be corrected on next update

@dvm-shlee dvm-shlee self-assigned this May 15, 2024
@dvm-shlee dvm-shlee added the bug Something isn't working label May 15, 2024
@dvm-shlee dvm-shlee modified the milestones: v0.4.1 release, BIDS May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants