Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bids_helper quits when method file is missing #145

Open
mschneider1711 opened this issue Jan 22, 2024 · 1 comment
Open

Bids_helper quits when method file is missing #145

mschneider1711 opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mschneider1711
Copy link

Describe the bug
The bids_helper catches an error when the dataset doesn't contain a method file. Even if this is the right behaviour, the script shouldn't break there if I want to convert many datasets to bids at the same time. It should rather neglect the scan without the method file and continue running for the rest.

The exact error catches where the method of the scan needs to be read out.
In brkraw.py line 319-320:
if not is_localizer(dset, scan_id, reco_id): method = dset.get_method(scan_id).parameters['Method']

To Reproduce
Steps to reproduce the behavior:
Run the bids_helper on a to nifti converted dataset which doesn't have a method file.

Expected behavior
The scan without the method file should be neglected and the script should continue running.

@dvm-shlee
Copy link
Member

Hi @mschneider1711,

Thank you for your input. We're aware of this issue, along with other BIDS helper crashes linked to unexpected scenarios in single scan data. Rest assured, these will be addressed in the next update. Until then, the simplest workaround is to delete the folder causing the problem from the dataset.

@dvm-shlee dvm-shlee self-assigned this Feb 5, 2024
@dvm-shlee dvm-shlee added the enhancement New feature or request label Feb 5, 2024
@dvm-shlee dvm-shlee added this to the v0.4.0 release milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants