Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting not working if "Service" is null #438

Open
1 task
n3cr0cr0w opened this issue Jan 2, 2025 · 1 comment
Open
1 task

Sorting not working if "Service" is null #438

n3cr0cr0w opened this issue Jan 2, 2025 · 1 comment
Labels
bug Something isn't working fixed The issue is fixed (in a coming release)
Milestone
v5.5.0

Comments

@n3cr0cr0w
Copy link

Version

5.4.3

Details & Steps to reproduce

Import an account that doesn't have a "Service" set. Try to sort AtoZ or ZtoA.

Expectation

Sorting should work even if service is null.

Error & Logs

The errors where on normalize() and localeCompare() functions when "Service" was null.

Execution environment

userAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
Version: 5.4.3
Environment: local
Install path: /2fauth
Debug: false
Cache driver: file
Log channel: daily
Log level: debug
DB driver: sqlite
PHP version: 8.3.15
Operating system: Linux
interface: apache2handler
Auth guard: web-guard
webauthn user verification: preferred
Trusted proxies: none
lastRadarScan: 2024-12-30 18:49:47

Containerization

  • Docker

Additional information

No response
@Bubka Bubka added the bug Something isn't working label Jan 2, 2025
@Bubka
Copy link
Owner

Bubka commented Jan 2, 2025

Nice find, thx for the report 👍🏻

@Bubka Bubka added the fixed The issue is fixed (in a coming release) label Feb 25, 2025
@Bubka Bubka moved this from Todo to Done in 2FAuth backlog Feb 25, 2025
@Bubka Bubka added this to the v5.5.0 milestone Feb 25, 2025
Bubka added a commit that referenced this issue Feb 26, 2025
@Bubka
Fix sorting fails when service is null - Closes #438
11db01e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed The issue is fixed (in a coming release)
Projects
2FAuth backlog
Status: Done
Milestone
v5.5.0
Development

No branches or pull requests
2 participants
@Bubka @n3cr0cr0w