Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@builder.io/react 5.0.4: Custom component are not working anymore #3609

Open
MaximeGratens opened this issue Oct 7, 2024 · 7 comments
Open

Comments

@MaximeGratens
Copy link

MaximeGratens commented Oct 7, 2024

Describe the bug
Since the new version of the sdk, custom component using <script> inside are not working anymore. After looking in details, it seems that the new version are deleting the script tag and his content.

@sidmohanty11
Copy link
Contributor

Hello @MaximeGratens could you please share a small repro case?

@samijaber
Copy link
Contributor

@MaximeGratens what was the last version where this behaviour worked for you?

@MaximeGratens
Copy link
Author

Hey guys,

So basically, we are using the builder.io/react with next js. The version working right now in production is "5.0.1".
When I upgraded to version 5.0.4, all <script> injected by custom constructor components were not injected.

I don't have any small repo to share with you. If I have times this week I will try but it's a basic next js project.

@MaximeGratens
Copy link
Author

Still the same issue in 7.0.0. You can ask me more details by mail but for me it seems that the custom component using <script> are not rendered.

@MaximeGratens
Copy link
Author

Interesting - I just tried upgrading Next.js to version 15 and React to version 19 while using Builder 7.
I got a hydration error, and this is the element that's not loading on the page

image

@samijaber @sidmohanty11

@Manish-Builder-io
Copy link

Steps To Reproduce:
. Clone the following repo https://github.com/Manish-Builder-io/next-15-builder-app.git
. Install the dependency and run the app, npm install && npm run dev
. Visit the following content to observe the error https://builder.io/content/07e0555027df4e0c84c19f375916f171

@MaximeGratens
Copy link
Author

Hello guys,

Any news on this topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants