Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] Firefox + Patytown + Astro View Transitions breaking links #486

Closed
OliverSpeir opened this issue Oct 31, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@OliverSpeir
Copy link

Describe the bug

When using Firefox to view a site with partytown and Astro View Transitions all links break

Reproduction repo: https://github.com/florian-lefebvre/astro-vt-fallback-bug
Reproduction on deployed site: https://astro-vt-fallback-bug.pages.dev/

Best description so far:

Using a build of partytown with minification turned off pointed me to a single line.

image

Partytown patches the History API, and its code runs whenever the History API is used. It seems like an issue for Firefox to fix, although Partytown may be able to remove this hacky code. Astro's usage of history API is necessary and proper.

Originally posted by @lilnasy in withastro/astro#8862 (comment)

Reproduction

https://github.com/florian-lefebvre/astro-vt-fallback-bug

Steps to reproduce

  1. Using Firefox browser
  2. Clone reproduction
  3. npm install && npm run dev
  4. Visit localhost:4321 and try clicking top nav links
  5. Or visit URL and try clicking top nav links

Browser Info

Firefox

Additional Information

No response

@gioboa
Copy link
Collaborator

gioboa commented Dec 29, 2023

#511 closed this one.

@gioboa gioboa closed this as completed Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants