Research how to implement the C# battle into Dojo Contracts

[danielcdz]

📖 Description

In recent weeks, we've experienced some changes in the battle logic within Unity. Currently, the logic in our Dojo Contracts does not reflect these updates. In this issue, we are looking for a dedicated contributor to review the C# battle logic and create a document with valuable insights, along with a small proof of concept (PoC) for implementing the battle mechanics into a Dojo Contract.

📓 Summary

• Review the relevant Unity scripts and identify those related to the battle mechanics.
  • Battle scripts are here and start with the prefix Battle.
• Study the code to fully understand the logic and mechanics.
• Create a document (preferably in Google Docs) to share with the maintainers.
• In the document, compile key insights such as an overview of the mechanics, key characteristics, important points about the battle system, and anything else you think would be useful.
• Prepare a small PoC with an initial implementation of the Dojo Contract. This PoC does not need to be fully functional but should serve as a foundation for further development, so don't feel pressured to deliver a complete contract.
  • The PoC can be placed in the document, use a tool to format the code to make it more readable.

📦 Deliverable

• A document with the requirements mentioned in the Summary.

⚠️ Notes

• We don't need to open a PR for this issue. we will review and add comments directly in the Google Doc.
• You will need experience in Cairo(Dojo Engine) and C# to be a good candidate for this issue.

[RolandoDrRobot]

These files help as reference:
This is the previous implementation in the dojo side, this could help has base for the POC

• https://github.dev/ByteBuildersLabs/ByteBeastsBackend/blob/4a3e7c62f229a21decd619bd22056db9593c7f80/src/systems/battle.cairo
• https://github.dev/ByteBuildersLabs/ByteBeastsBackend/blob/4a3e7c62f229a21decd619bd22056db9593c7f80/src/tests/test_battle.cairo

C# Unity scripts

• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleChar.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleMagicSelect.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleManager.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleMove.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleNotification.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleReward.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleStarter.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BattleTargetButton.cs
• https://github.dev/ByteBuildersLabs/ByteBeastsFrontend/blob/02f8ebfdfa82ed078cd1639c68982361b03bafd3/Assets/Scripts/BAttleType.cs
• And other files from that folder

[KevinMB0220]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I'm from Dojo Coding. To complete this task, I’ll first review the Unity scripts related to the battle mechanics, focusing on those with the prefix "Battle". I’ll thoroughly study the logic to fully understand how the mechanics work. Then, I’ll compile a document summarizing key aspects, including an overview of the mechanics, important characteristics, and other relevant points about the battle system. Finally, I’ll create a small Proof of Concept (PoC) for a Dojo contract that reflects the battle mechanics, which will serve as a foundation for future development. The PoC won’t be fully functional but will provide a solid starting point. The document will be shared with the maintainers via Google Docs.

[martinvibes]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

ello @ i'm a frontend developer and an experienced technical writer i would love to work on this issue
Pleasee kindly assign :)

[suhas-sensei]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i have experience in game dev as well as blockchain previously as personal projects and OS, so hoping to make use of them here and mark my first odhack contribution

How I plan on tackling this issue

I will write it in the form of a comparison and optimization of the battle system and render an overall analysis, including parallel execution diagrams showing how moves, states, and rewards are handled differently between the Unity and Dojo implementations.

[BrunoAmbricca]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hey guys, Bruno here from the dojo coding community. I´ve been coding with c# for the past 4 years in many jobs and been for the past 2 months working with dojo engine on the project of my own team, encountering many problems and solving them.

How I plan on tackling this issue

I would read all the docs and code you already have and start designing a solution based of creating different modules that do different key tasks to then unite them into the final result.

[ShantelPeters]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have extensive experience in both Cairo and C# programming, with a focus on smart contract development and game mechanics in Unity. My background includes analyzing and implementing complex game logic, which allows me to effectively bridge the gap between game design and smart contract functionality. I have previously documented intricate systems, ensuring clarity and usability for future developers and maintainer

How I plan on tackling this issue

To address the alignment of the Dojo Contracts with the updated battle logic in Unity, I will first review the relevant battle scripts to understand their mechanics thoroughly. Following this, I will document key insights, including an overview of the battle mechanics, key characteristics, and implementation notes in a structured Google Doc. Additionally, I will develop a small proof of concept (PoC) for integrating the battle mechanics into a Dojo Contract, providing a basic structure without the need for full functionality. The PoC will be included in the document, formatted for readability, and I will seek feedback from the maintainers to ensure clarity and usability for future development.

[aniruddhaaps]

I'm a c# dev. A new-comer here, willing and ready to contribute to solve the issue.

[emarc99]

Would love to tackle this!

I have a computer engineering bachelors, and I programmed in C/++/# for different embedded systems projects. I also do research works related to computer science as freelance. Currently, I'm close to completing node guardians and starkling cairo paths.

[bitfalt]

I'm a web3 developer with experience in Unity creating VR/AR applications, so I'm familiarized with C#. Also, I have a vast experience developing smart contracts in Cairo to understand how to implement the battle logic. I've done a few small projects using Godot Engine, to understand the game logic behind a battle.

To tackle this issue I would do the following:

• Read and understand fully the C# battle logic and its components (characters, beasts, etc), if any doubts come up while doing this I'll ask the maintainers for clarification.
• I'll start making a draft of the document with key insights of the battle mechanics
• Once the draft is approved and feedback from the maintainers is received, I'll start making the PoC of the Dojo Contract.
• Eventually, I'd love to help make the PoC a complete smart contract.

[danielcdz]

@bitfalt hello! do you have any updates?

[bitfalt]

hii! So far understanding the code. I was wondering where should I send you the Google Docs? Let me know if Telegram is fine :D

[danielcdz]

Telegram is ok! @bitfalt