Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully typed Python code #48

Open
C0rn3j opened this issue Oct 6, 2024 · 0 comments
Open

Fully typed Python code #48

C0rn3j opened this issue Oct 6, 2024 · 0 comments

Comments

@C0rn3j
Copy link
Owner

C0rn3j commented Oct 6, 2024

This is a pipe dream for now, the code base is quite large, only a small part of it has been typed so far.

There are various bugs which are easily revealed by adding function types, and then having Ruff/Pyright take a look at the errors.
Since the original codebase is Python 2, the code was not written with types in mind.

It would be nice to have some test that ensured that everything is typed - maybe Ruff/Pyright have a rule we could use for this?
At least a soft-error/warning one that would inform about the amounts of issues in the various files.

This would also possibly include having types in the libraries we depend on, some of which are tiny.
That will most likely require us to send them a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant