Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dimensionless units in CABLE offline output to be CF-compliant #405

Open
SeanBryan51 opened this issue Sep 19, 2024 · 4 comments
Open

Comments

@SeanBryan51
Copy link
Collaborator

SeanBryan51 commented Sep 19, 2024

Variables in the CABLE offline model output which are dimensionless have their units attribute set to - which does not comply with the CF-conventions (see units section). The units attribute for dimensionless variables should have units set to 1 or have no units attribute defined.

@SeanBryan51
Copy link
Collaborator Author

SeanBryan51 commented Sep 19, 2024

This is required for CABLE output to work directly with ILAMB (#210). See CABLE-LSM/benchcab-ilamb-config#1 for more details.

@SeanBryan51 SeanBryan51 self-assigned this Sep 24, 2024
@SeanBryan51 SeanBryan51 linked a pull request Sep 24, 2024 that will close this issue
5 tasks
@SeanBryan51
Copy link
Collaborator Author

It looks like CABLE currently is working with the ALMA standard for its input and output files which sets the units attribute for dimensionless quantities to -. I think there needs to be a discussion in the community if the ALMA standard should be superseded by the CF conventions.

@SeanBryan51
Copy link
Collaborator Author

ALMA conventions also documented here: https://modelevaluation.org/variableStandards

@SeanBryan51
Copy link
Collaborator Author

Gab (@gabsun) informed me that the ALMA standard is typically updated on a per MIP basis and suggested that ALMA could be updated to be CF compliant.

@SeanBryan51 SeanBryan51 removed their assignment Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant