Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote PBS related constants to parameters in the config file #104

Closed
SeanBryan51 opened this issue Jul 4, 2023 · 0 comments · Fixed by #121
Closed

Promote PBS related constants to parameters in the config file #104

SeanBryan51 opened this issue Jul 4, 2023 · 0 comments · Fixed by #121

Comments

@SeanBryan51
Copy link
Collaborator

SeanBryan51 commented Jul 4, 2023 •
edited
Loading

Currently PBS constants (PBS flags) are defined internally in benchcab. These should be promoted to optional parameters in the configuration file so that PBS flags can be set at runtime.

This is useful in running multiple benchcab instances with different job parameters such as memory and the number of CPUs. This will also allow us to easily find an optimal number of CPUs to use to maximise performance.
SeanBryan51 added a commit that referenced this issue Jul 28, 2023
@SeanBryan51
Promote PBS constants to optional parameters
08c04bb 
This change promotes PBS related constants to optional parameters in the
configuration file so that PBS flags can be set at runtime.

This is useful in running multiple benchcab instances with different job
parameters such as memory and the number of CPUs. This will also allow
us to easily find an optimal number of CPUs to use to maximise
performance.

This change also adds the ability to switch on and off multiprocessing
at runtime via an optional parameter in the config file.

Fixes #104
@SeanBryan51 SeanBryan51 mentioned this issue Jul 28, 2023
Merged
@SeanBryan51 SeanBryan51 linked a pull request Jul 28, 2023 that will close this issue
Promote PBS constants to optional parameters #121
Merged
SeanBryan51 added a commit that referenced this issue Jul 28, 2023
@SeanBryan51
Promote PBS constants to optional parameters
4d07515 
This change promotes PBS related constants to optional parameters in the
configuration file so that PBS flags can be set at runtime.

This is useful in running multiple benchcab instances with different job
parameters such as memory and the number of CPUs. This will also allow
us to easily find an optimal number of CPUs to use to maximise
performance.

This change also adds the ability to switch on and off multiprocessing
at runtime via an optional parameter in the config file.

Fixes #104
SeanBryan51 added a commit that referenced this issue Aug 7, 2023
@SeanBryan51
Promote PBS constants to optional parameters
78ad39d 
This change promotes PBS related constants to optional parameters in the
configuration file so that PBS flags can be set at runtime.

This is useful in running multiple benchcab instances with different job
parameters such as memory and the number of CPUs. This will also allow
us to easily find an optimal number of CPUs to use to maximise
performance.

This change also adds the ability to switch on and off multiprocessing
at runtime via an optional parameter in the config file.

Fixes #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promote PBS constants to optional parameters CABLE-LSM/benchcab
1 participant
@SeanBryan51