Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Reconnect button does not remember server resource pack setting. #5183

Closed
leumasme opened this issue Jan 4, 2025 · 0 comments · Fixed by #5197
Closed

[BUG] Reconnect button does not remember server resource pack setting. #5183

leumasme opened this issue Jan 4, 2025 · 0 comments · Fixed by #5197
Labels
🐛 bug Something isn't working 🌑 nextgen
Milestone
0.24.0

Comments

@leumasme
Copy link
Contributor

leumasme commented Jan 4, 2025

LiquidBounce Branch

Nextgen

LiquidBounce Build/Version

master branch head

Operating System

Windows 10

Minecraft Version

1.21.1 / 1.21.4 / no viaversion

Describe the bug

The "Reconnect" button on the disconnect screen always uses "Prompt" as the server resource pack policy, instead of the server resource pack policy that the player has chosen for the server.
The ServerInfo gets initialized without setting the resourcePackPolicy, causing it to default to ServerInfo.ResourcePackPolicy.PROMPT

LiquidBounce/src/main/kotlin/net/ccbluex/liquidbounce/features/Reconnect.kt

Lines 41 to 43 in 0968c1d

val handleServerConnect = handler<ServerConnectEvent> {
lastServer = ServerInfo(it.serverName, it.serverAddress, ServerInfo.ServerType.OTHER)
}

Steps to reproduce

  • add a server that has a server resource pack to server list
  • set server resource pack setting to enabled
  • join server
  • notice: the "do you want to download the server resource pack" screen does not appear
  • get disconnected
  • click reconnect button
  • notice: the "do you want to download the server resource pack" screen DOES appear

Client Log

-

Screenshots

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🌑 nextgen
Projects
None yet
Milestone
0.24.0
Development

Successfully merging a pull request may close this issue.

feat(reconnect): Remembers server resource-pack policy L1shed/LiquidBounce
2 participants
@1zun4 @leumasme