Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should not be able to join the beacon he/she is already part of. #76

Open
Aadeesh11 opened this issue Dec 29, 2021 · 4 comments
Open

Comments

@Aadeesh11
Copy link
Collaborator

User should not be able to join the beacon he is already part of (i.e., either he is a leader or follower). As all the beacons he is a part of are displayed under your beacons and can be navigated from there.
Secondly, when the beacon's details are fetched using query beacon(...) leader's name is returned as null, because of which Anonymous is getting displayed.

Originally posted by @nb9960 in CCExtractor/beacon#48 (comment)

@Aadeesh11 Aadeesh11 changed the title User should not be able to join the beacon he is already part of. User should not be able to join the beacon he/she is already part of. Dec 29, 2021
@aadibajpai
Copy link
Member

@Aadeesh11
Copy link
Collaborator Author

this shouldn't be possible already https://github.com/CCExtractor/beacon-backend/blob/master/graphql/resolvers.js#L120

If the user(who created the beacon) is the leader himself, in that case user can join the beacon.

@aadibajpai
Copy link
Member

this shouldn't be possible already https://github.com/CCExtractor/beacon-backend/blob/master/graphql/resolvers.js#L120

If the user(who created the beacon) is the leader himself, in that case user can join the beacon.

that is also a remnant of testing, so that a single user can test a beacon out by trying to join it after creating it. Should be easy to remedy. Might be worth to only do it when not running application in development so that it is still possible to test like that

@Aadeesh11
Copy link
Collaborator Author

Ok, understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants