Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should DeterministicVariable be able to have an arbitrary pytree as their vars value? #308

Open
gvegayon opened this issue Jul 24, 2024 · 0 comments
Open

Should DeterministicVariable be able to have an arbitrary pytree as their vars value? #308

gvegayon opened this issue Jul 24, 2024 · 0 comments
Labels
discussion

Comments

@gvegayon
Copy link
Member

We should discuss elsewhere whether DeterministicVariables should be able to have an arbitrary pytree as their vars value. I lean yes.

I would also support renaming vars to value, for consistency with SampledValue.

Originally posted by @dylanhmorris in #262 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gvegayon @damonbayer