Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prior predictive checks: models all comparable? #4

Open
SamuelBrand1 opened this issue Feb 7, 2024 · 10 comments
Open

Prior predictive checks: models all comparable? #4

SamuelBrand1 opened this issue Feb 7, 2024 · 10 comments

Comments

@SamuelBrand1
Copy link
Collaborator

No description provided.

@SamuelBrand1 SamuelBrand1 mentioned this issue Feb 7, 2024
11 tasks
@SamuelBrand1
Copy link
Collaborator Author

My intention here is that there is a sub-directory of test that has prior predictive check visualisations. Let me know any extra analysis we want here?

@seabbs
Copy link
Collaborator

seabbs commented Feb 7, 2024

That sounds very sensible to me

@SamuelBrand1
Copy link
Collaborator Author

This might just be a placeholder... locally I render using Literate... so prior pred checks could end up in the docs

@seabbs
Copy link
Collaborator

seabbs commented Feb 7, 2024

ah yes that would also be nice

@seabbs
Copy link
Collaborator

seabbs commented Feb 7, 2024

or as a doctest?

@seabbs seabbs added this to the EpiAware 0.1.0 milestone Feb 29, 2024
@SamuelBrand1
Copy link
Collaborator Author

or as a doctest?

We can use Documenter.@example in the doc strings to do this.

@seabbs
Copy link
Collaborator

seabbs commented Jun 11, 2024

Is this 1 done. 2. part of the pipeline or 3. needing a rewrite for where we are now?

@SamuelBrand1
Copy link
Collaborator Author

Its 3. needing a bit of a rewrite.

In particular, as discussed f2f we need to choose appropriate priors dependent on the infection generating process.

For example, I think its reasonable to say in any given scenario that the exponential growth rate is with close to probability one in $[-0.35, 0.35]$ (e.g. doubling time is less than 2 time steps) whereas log(Infections) would be on a somewhat different scale.

This needs to be written in and prior predictive checking done to validate that our prior beliefs about the kind of infection processes we are modelling is accurately reflected in our parameter priors.

@SamuelBrand1
Copy link
Collaborator Author

Because we are considering different mean generation times we should probably consider our priors in light of that too.

@SamuelBrand1
Copy link
Collaborator Author

It turns out that switching to daily/one time step increments seems to create overflow edge cases (e.g. #433 ). This highlights the need to complete this issue.

It is (obviously) also part of the analysis plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants