-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support disease filter on results CSV download #8052
Conversation
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Since these queries are already called out as candidates for refactoring in the future, I think we could probably be safe with "Accepting" the SonarCloud issues that identify the method using 8 parameters instead of 8. But let me know if anyone would prefer this addressed in this PR instead of the follow up refactor ticket. |
@@ -2504,27 +2549,30 @@ private List<TestEvent> makedata() { | |||
return testEvents; | |||
} | |||
|
|||
private List<TestEvent> makeSpecificDiseaseData(SupportedDisease disease) { | |||
private List<TestEvent> makeSpecificDiseaseData(SupportedDisease disease, Facility site) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a parameter to pass in a specific site so that one of the tests can use the global instance variable facility site rather than a new disease specific facility created below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! tested on dev5 and filters worked as expected!
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Additional Information
ResultResolver.resultsPage
which then callsResultService.getFacilityResults
orResultService.getOrganizationResults
. These service methods then callResultRepository.findAll
and pass in a JPASpecification<Results>
that is created with the Jakarta criteria builder inbuildResultSearchFilter
.TestResultResolver.testResultsPage
which then callsTestOrderService.getOrganizationTestEventsResults
orTestOrderService.getFacilityTestEventsResults
. These service methods then callTestEventRepository.findAll
and pass in a JPASpecification<TestEvent>
that is created with the Jakarta criteria builder inbuildTestEventSearchFilter
.buildTestEventSearchFilter
andbuildResultSearchFilter
there is fairly identical logic for applying the filters on the joins.GraphQL backwards compatibility
Testing