Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into updating NextJS version to 15 #153

Open
jupiter007 opened this issue Oct 24, 2024 · 3 comments
Open

Look into updating NextJS version to 15 #153

jupiter007 opened this issue Oct 24, 2024 · 3 comments
Assignees

Comments

@jupiter007
Copy link
Collaborator

Make sure to test that nothing breaks.

@jupiter007 jupiter007 self-assigned this Oct 24, 2024
@jupiter007
Copy link
Collaborator Author

jupiter007 commented Nov 13, 2024

Seems like there's a known issue of getting sass errors when updating to NextJS 15. Sounds like sass-loader version needs to be updated in NextJS 15: vercel/next.js#71638 and NextJS 14 security updates are still supported (https://endoflife.date/nextjs).

There are also conflicts with Remirror's getRootProps in EditorComponent loading more than once in NextJS. One way to prevent this is to block "Strict mode", but I really don't want to have to do that.

We might want to consider holding off on this upgrade until some issues are hopefully fixed. I'm going to time box researching this to one more day, and if I can't find solutions, I'm going to Icebox this ticket.

@jupiter007
Copy link
Collaborator Author

I made a bunch of updates to address errors that arose from upgrading to NextJS version 15. However, some issues remain that are not easily fixable, without turning off Strict mode for the development environment, which automatically loads a component twice. Remirror, specifically the EditorComponent in Remirror, attaches getRootProps to the DOM twice because of this strict mode. We can either turn off strict mode for the app to resolve this issue, or wait for @remirror/react to make an update so that it can work around this situation.

@jupiter007 jupiter007 changed the title Look into updating NextJS version to 15 [Spike] Look into updating NextJS version to 15 Nov 13, 2024
@jupiter007
Copy link
Collaborator Author

jupiter007 commented Nov 14, 2024

I am going to Icebox this for now. I don't want to turn of "Strict mode" for the app, and that currently seems to be the only way to prevent Remirror errors.

I will check back in several months to see if @remirror/react was updated to fix the issue. As mentioned before, NextJS 14, the version we are currently using, is still supported so it's ok to wait a bit.

@bofstein bofstein changed the title [Spike] Look into updating NextJS version to 15 Look into updating NextJS version to 15 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant