Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subcategory vs category2 in xpaths #228

Open
wkdewey opened this issue Jun 6, 2024 · 1 comment
Open

Subcategory vs category2 in xpaths #228

wkdewey opened this issue Jun 6, 2024 · 1 comment
Assignees
@wkdewey
Labels
Discuss issues that require discussion before moving forward
Milestone
Future release

Comments

@wkdewey
Copy link
Contributor

wkdewey commented Jun 6, 2024

We did not change the xpath label when we changed the api field name for v2. It is easy to overlook this when making site transitions. But if we change it, there might be code in Whitman and Petitioning for Freedom (two sites that are already using the new APIv2) that also need to change
@wkdewey wkdewey self-assigned this Jun 6, 2024
@wkdewey wkdewey transferred this issue from CDRH/orchid Jun 6, 2024
@wkdewey
Copy link
Contributor Author

wkdewey commented Jun 6, 2024

also for image_id which was changed to cover_image. looks like we didn't change any of the xpath labels

@wkdewey wkdewey added the Discuss issues that require discussion before moving forward label Aug 8, 2024
@wkdewey wkdewey added this to the Future release milestone Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wkdewey wkdewey

Labels
Discuss issues that require discussion before moving forward
Projects
None yet
Milestone
Future release
Development

No branches or pull requests
1 participant
@wkdewey