From c93b9d43dc70a0d0a1cd12221c308bc22c74a7c0 Mon Sep 17 00:00:00 2001
From: floatingsnake <1227073631@qq.com>
Date: Tue, 26 Sep 2023 10:44:47 +0900
Subject: [PATCH] add datatype of config

---
 megatron/neox_arguments/neox_args.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/megatron/neox_arguments/neox_args.py b/megatron/neox_arguments/neox_args.py
index 1ac062e4d..965f2e474 100644
--- a/megatron/neox_arguments/neox_args.py
+++ b/megatron/neox_arguments/neox_args.py
@@ -1133,11 +1133,12 @@ class NeoXArgsTraining(NeoXArgsTemplate):
     """ 
 
     finetune_groups_key_words = ['image_prefix']
+    #TODO add data type to make it editable in the config, hardcode image_prefix for now.
     """
     parameter will be putted into fintune groups as long as its name contain one of these keywords
     """
 
-    finetune_factor = 1/400
+    finetune_factor:float = 1/400
     """
     control the learning rate of fintuned groups, whose real_lr=lr*finetune_factor
     """