Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desgin/Prototype uploading video files as additional files #1983

Open
jrcastro2 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1984
Open

Desgin/Prototype uploading video files as additional files #1983

jrcastro2 opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1984

Comments

@jrcastro2
Copy link
Contributor

Currently if a video file is uploaded it will replace the master file. There is no support for video files other than the master file. We need to change this to support uploading presenter and presentation of weblectures as additional files.

@zubeydecivelek
Copy link
Contributor

zubeydecivelek commented Nov 27, 2024

RFC Uploading video files as additional files

Current Behavior
When video files uploaded as a complimentary file, the first video file replaces the master video and starts the workflow, which includes video metadata extraction, frame extraction, and transcoding.
Image
Image

Changes

  • Added separate interfaces for:

    • Uploading additional files.
    • Replacing the master file.
      Image
  • Separated the replace master file behavior into its own function and refactored add_files to handle additional files without triggering the workflow.

Future Work

  • Modify the context_type and tags of additional files because they're implemented as subtitles and vtt
{
"content_type": "mp4",
"context_type": "subtitle",
"key": "complimentary_video.mp4",
"tags": {
"content_type": "vtt"
}
}
  • UI: Subtitle displaying it not correct
    Image

  • UI: Improve the UI for uploading additional files and replacing the master file

@zubeydecivelek zubeydecivelek linked a pull request Nov 27, 2024 that will close this issue
@zubeydecivelek zubeydecivelek linked a pull request Nov 27, 2024 that will close this issue
@zubeydecivelek zubeydecivelek moved this from In progress to In review 🔎 in Sprint Q4/2024 🎄 Nov 29, 2024
@ntarocco ntarocco moved this from In review 🔎 to In progress in Sprint Q4/2024 🎄 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants