Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The original MinerInfo.peer_id field of the storage miner is no longer applicable #404

Closed
0xbillw opened this issue Oct 9, 2024 · 0 comments · Fixed by #428
Closed

The original MinerInfo.peer_id field of the storage miner is no longer applicable #404

0xbillw opened this issue Oct 9, 2024 · 0 comments · Fixed by #428

Comments

@0xbillw
Copy link
Member

0xbillw commented Oct 9, 2024

Cause

The current version of MinerInfo.peer_id represents the ID of the storage-miner P2P node. Due to the change of data transmission protocol for storage-miner, this field no longer has practical significance. On the other hand, the information used to represent the endpoint of the storage-miner borrows this field, resulting in improper expression of business semantics and making it difficult for future code maintenance.

Advices

  1. Deprecate the MinerInfo.peer_id field
  2. Add a field similar to endpoint to represent the API endpoint of the storage miner

Affect modules

  1. cess
  2. cess-miner
  3. cess-go-sdk
  4. other downside modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant