Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing outdated cgal_header_clean_up.py in developer scripts. #8696

Open
SharonIV0x86 opened this issue Jan 16, 2025 · 2 comments
Open

Fixing outdated cgal_header_clean_up.py in developer scripts. #8696

SharonIV0x86 opened this issue Jan 16, 2025 · 2 comments

Comments

@SharonIV0x86
Copy link
Contributor

SharonIV0x86 commented Jan 16, 2025

Issue Details

Fixing outdated cgal_header_clean_up.py script in developer script folder of the project. Here
The current version of the cgal_header_clean_up.py script, which was last updated 14 years ago, is written in an outdated Python version and no longer works properly. It needs to be migrated to Python 3 and fixed to correctly format copyright holder names, placing each name on a separate line. I would like to make this change. If this issue is assigned to me i will make sure that cgal_header_clean_up.py works as intended.

Environment

  • Operating system: Linux x64
  • Compiler: g++ MinGW
  • CGAL version:6.0.1
  • Other libraries versions if used (Eigen, TBB, etc.) N/A:
@SharonIV0x86 SharonIV0x86 changed the title Fixing outdated cgal_head_clean_up.py in developer scripts. Fixing outdated cgal_header_clean_up.py in developer scripts. Jan 16, 2025
@sloriot
Copy link
Member

sloriot commented Jan 17, 2025

The script has only been used 14 years ago for updating some files. It is kept for archive.

@SharonIV0x86
Copy link
Contributor Author

The script has only been used 14 years ago for updating some files. It is kept for archive.

Might be possible that it's required in future someday, wouldn't it be better to update it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants