Issues in dD Triangulation

[efifogel]

Issues in dD Triangulation

1. In Triangulation_data_structure.h the function mirror_vertex() has several problems:
   • I believe that the return type should be Vertex_handle.
   • The call s->mirror_vertex(i) is missing the cur_dim second parameter.
   • Also, the const version of mirror_vertex() is missing. As a matter of fact, several
     const or mutable versions are missing in all constructs in this package.
2. In Triangulation_data_structure.h, the body of the function collapse_face() defines a
   Full_face using the default constructor (namely, Full_cell s), but the default
   constructor is canceled. (There is one that accepts the dimension...)
3. In the manual of insert_in_tagged_hole(..., OutputIterator oi) please explicitly indicate the type of the dereferenced object *oi.
4. In the manual of insert_in_hole(ForewardIterator start, ForwardIterator end, ...) the text says, and I quote, "Removes the full cells in the range C=[s, e)". Change s and e to start and end, respectively (or the other way around...)
5. In both variants of insert_in_hole() and in insert_in_tagged_hole() the input parameter facet should probably be passed as a reference (and not by value).
6. The manual of Triangulation lists the function collapse_face(), while the code as contract_face(). This function also calls the member contract_face() of Triangulation_data_structure, while the latter has collapse_face().

Source Code

Environment

• Operating system (Windows/Mac/Linux, 32/64 bits): All
• Compiler: All
• Release or debug mode: Both
• Specific flags used (if any):
• CGAL version: Latest
• Boost version: Irrelevant
• Other libraries versions if used (Eigen, TBB, etc.):