Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh_3: Compile time optimisations of surface_only() #8812

Open
sloriot opened this issue Mar 28, 2025 · 1 comment
Open

Mesh_3: Compile time optimisations of surface_only() #8812

sloriot opened this issue Mar 28, 2025 · 1 comment

Comments

@sloriot
Copy link
Member

sloriot commented Mar 28, 2025

I wonder if there is a way to use that Boolean surface_only at compile time. Compiling Mesh_3 with parameters::surface_only() should be faster than without, and the resulting code should similar to surface_mesher. Maybe even the type of Vertex and Cell could be simpler with surface_only().

Originally posted by @lrineau in #8781 (comment)

@sloriot
Copy link
Member Author

sloriot commented Mar 28, 2025

You can make surface_only a bool template parameter to the class Mesh_3_options instead of a data member, but I think it is probably out of the scope of this PR and a dedicated issue should be opened.

@lrineau lrineau changed the title Compile time optimisations of surface_only() Mesh_3: Compile time optimisations of surface_only() Mar 28, 2025
@sloriot sloriot added this to the 6.2-beta milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants