Skip to content
This repository has been archived by the owner on Dec 12, 2017. It is now read-only.

Path Segments are incorrectly locked when extending guide from existing contours #63

Open
carter2422 opened this issue May 31, 2014 · 11 comments
Assignees
Labels
Milestone

Comments

@carter2422
Copy link
Member

You cannot adjust the loop segment count when extending an existing set of contour strokes with a guide. The header reports "Path is locked, cannot adjust segments".

This is incorrect.

The loop vertex count should be locked, but the number of segments should not be. When adjusting loop count in a a guide-drawn-segment it's only changing the number of loops between the start and then end. It shouldn't matter that it's starting at a previous contour stroke.

Is there a reason for locking the path?

@patmo141
Copy link
Contributor

So you want to adjust the number of rings in the newly extended part? Thats a slight prob because the whole segment is merged, making it one new big one. It picks how many more to add based on ring spacing of the original path.

@carter2422
Copy link
Member Author

Ideally yes, that's what I'd like.

Is there a reason for merging them?

If it's better to merge them, then would it be feasible to adjust the loop count for the entire, merged section? Such that the distribution is always based on a single count.

@patmo141
Copy link
Contributor

Well...then u might loose any previous adjustment to the original segment. The benefit of merging is that it keeps the geometry contiguous

@patmo141
Copy link
Contributor

We could leave them unmerged until mesh creation, but then you cant adjust the terminal cut of the initial segment because it will be a duplicate of the initial cut of the extension segment. Unless we somehow account for a single cut belonging to multiple segments [head explodes]

@carter2422
Copy link
Member Author

What about merging either upon Mesh Creation OR upon leaving Guide Mode?

@patmo141
Copy link
Contributor

I think it best to lock the whole new merged path if the original segment is locked or to let the whole path be redistributed after merging.

Then wait for multi select when we can do interpolation and redistribution between any two given rings

@carter2422
Copy link
Member Author

How does that affect the ability to change segment count? I'm not sure I follow what you mean (but am happy to wait for multi-select for ideal workflow).

@patmo141
Copy link
Contributor

re merging post guide mode exit: Its a lot to keep track of,however its a good idea.

@patmo141
Copy link
Contributor

Re ability to change ring count: It would either eliminate it if the segment had previously been manually cut into or force redistribution of the whole segment when altering ring count.

@patmo141
Copy link
Contributor

New Behavior in Guide Mode:

  1. If a path is unlocked wrt the number of rings (eg, it has been generated only by drawing a guide stroke, with no new cuts added in loop mode), the entire (newly merged) path can be redistributed and the number of rings altered.
  2. If a path has been previously edited on the cut/ring level, the number of strokes is estimated based on what is there.

This follows the workflow that: Guide mode is for bulk generation of strokes and that bulk generation should happen before tweaks in position, non uniform distribution of cuts, alignmeent and shift etc are altered.

Until multi-select allows for editing of arbitrary segments within a guide stroke, this is the cleanest, easiest to implement and most predictable across all use cases.

@carter2422
Copy link
Member Author

This has been drastically improved. Going to move to Milestone 1.2 for additional improvements once multi-select is in.

@carter2422 carter2422 modified the milestones: 1.1, 1.2 Jun 25, 2014
@carter2422 carter2422 modified the milestones: Contours 1.2, Contours 1.3 Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants