Audit changes

[sebastianelsner]

We are thinking about if it may be worth adding a audit system to afanasy server, which records in a text file all the changes that were done manually in the UI or via any tool on a job, a branch etc.

@timurhai What would be the best way to go about this? can you point me into a direction in the source code which is most central to capture this info? Maybe I can then build it myself.

[timurhai]

Hello! Sorry for a delay.
Each node has a log and a method to add line to it.
Any change produces a line of log.
By default node keeps 100 lines (af_node_log_lines_max).
The method, can add same line to some file.
But there should be some mechanism to rotate log files and delete old.

[sebastianelsner]

Ok, this helps. Additional questions: What is the best place to call the appendLog() if i want to log for example:

"job XXX priority changed from X to Y by user Z"?

[timurhai]

There is already AfNodeSrv::appendLog function that called on each change (action).
We can add some static function to log all nodes in one file (and file rotation).

[timurhai]

Hello!
There already store statistics in SQL database.
May be it should use SQL to log all changes too?
And database engine will process storing, clearing, searching?

[sebastianelsner]

Yes, sure I can totally imagine this being in the database.

[timurhai]

Hello!
So, what do you think about the schema?
I think, it can be something like:

int64_t     m_time;
std::string m_author;
std::string m_address;
std::string m_type;
std::string m_info;

At the time | user (author) | from IP | jobs | jobname@jobusername was deleted.