Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting and filtering #1

Open
dave-burke opened this issue Dec 28, 2023 · 1 comment
Open

Sorting and filtering #1

dave-burke opened this issue Dec 28, 2023 · 1 comment

Comments

@dave-burke
Copy link

Hi! I see on the README that you would like to have sorting and filtering of songs. Would you be open to a PR for this? I'm a Java developer professionally. I have never worked on an Android app, but am looking for an excuse to learn.

If you are open to PRs, let me know if you want it done a certain way (implementation or user interface).

Either way, thanks for a great app! I really like it.

@CGrassin
Copy link
Owner

Hi Dave!

Thank you for you interest in the project! Of course, your contribution would be appreciated!

The implementation of such a feature is quite simple: in fact, it is already kind of included in the codebase, because it is the same thing as the search. However, the reason I have not added it is that I don't really know how to handle the UI/UX aspect in a way that makes sense. You are more that welcome to propose something!

To be fully honest, although it is originally a user requested feature, I don't fully see the point of having filters. However, a very similar feature that was also requested is to add favorites, which I have an easier time seeing the benefit of.

Thanks again,
Charles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants