Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix workspace CLI Command #31

Closed
4 tasks done
shinybrar opened this issue May 8, 2024 · 0 comments · Fixed by #40
Closed
4 tasks done

[Bug] Fix workspace CLI Command #31

shinybrar opened this issue May 8, 2024 · 0 comments · Fixed by #40
Assignees
Labels
BUG Something isn't working

Comments

@shinybrar
Copy link
Contributor

shinybrar commented May 8, 2024

  • When doing a workflow workspace set command
    • Make the configuration folder to be ~/.config/workflow/workspace.yaml filename
    • Do not copy the source, from wherever you get it, to the the ~/.config/workflow/ folder at all

The general idea is, we will ship some configs, but we will also let people set configs, via a URL provided during workflow workspace set https://workflow.config.yaml

  • Write tests, if not already to make sure the new folder location is always clean.
  • Additionally, break all locations where workspace is used, e.g. in the Work, HTTPContext etc. objects, and raise a clear exception, Pydantic FilePath Error informing the user to run the workflow set command from the HTTPContext
@shinybrar shinybrar added the BUG Something isn't working label May 8, 2024
@odarotto odarotto linked a pull request May 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants