Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UWP broken by Unicode support in 2.4 #997

Open
henryiii opened this issue Feb 5, 2024 · 1 comment
Open

UWP broken by Unicode support in 2.4 #997

henryiii opened this issue Feb 5, 2024 · 1 comment

Comments

@henryiii
Copy link
Collaborator

henryiii commented Feb 5, 2024

The UWP tests in vcpackage are reporting:

C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1438~1.331\bin\Hostx64\x64\cl.exe   /TP -DCLI11_COMPILE -ID:\b\cli11\src\v2.4.0-2775f05bcd.clean\include /DWIN32 /D_WINDOWS /D_UNICODE /DUNICODE /DWINAPI_FAMILY=WINAPI_FAMILY_APP /D__WRL_NO_DEFAULT_LIB__ /nologo /Z7 /MP /GS /Gd /Gm- /W3 /WX- /Zc:wchar_t /Zc:inline /Zc:forScope /fp:precise /Oy- /EHsc  /utf-8  /D_DEBUG /MDd /Od /RTC1  -MDd /showIncludes /Fosrc\CMakeFiles\CLI11.dir\Precompile.cpp.obj /Fdsrc\CMakeFiles\CLI11.dir\CLI11.pdb /FS -c D:\b\cli11\src\v2.4.0-2775f05bcd.clean\src\Precompile.cpp
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(69): error C3861: 'CommandLineToArgvW': identifier not found
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): error C3536: 'wargv': cannot be used before it is initialized
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): error C2446: '==': no conversion from 'nullptr' to 'int'
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(72): note: A native nullptr can only be converted to bool or, using reinterpret_cast, to an integral type
D:\b\cli11\src\v2.4.0-2775f05bcd.clean\include\CLI/impl/Argv_inl.hpp(78): error C2109: subscript requires array or pointer type

See microsoft/vcpkg#36589 (comment).

@henryiii
Copy link
Collaborator Author

henryiii commented Feb 5, 2024

As far as I can tell, Microsoft has deprecated UWP a few years ago (https://www.thurrott.com/dev/258377/microsoft-officially-deprecates-uwp), and I'm not sure a CLI interface makes much sense in a UWP app anyway. So I think the best course of action might be to disable UWP in vcpkg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant