Use ssl to connect to databases in lambdas #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdettmannnava
changed the title
ashley-weaver
approved these changes
Nov 21, 2024
|
is this needed for the api-waf-sync lambda as well? IIRC it uses the same command |
Probably; but does that even run on prod? |
not currently, to my knowledge |
|
I know this is out the door but I believe with regard to testing, you can either adjust the logging configuration on the postgresql server to log connections and their config and/or there are system tables/views that will show active connections, including whether they are using ssl, so you can do inspection of either of those things to confirm that lambdas are indeed using ssl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/DPC-4415
🛠 Changes
Conditionally force sslmode depending on environment
ℹ️ Context
In our upgrade to postgres 16, we have to use ssl. We had ssl turned off for our lambdas so they could run against our local database (for testing), which are not set up for ssl. New code runs in sslmode except when 'testing' (which includes running locally)
🧪 Validation
Tested both locally (test and run-local)
Uploaded export to test and it worked.
Uploaded import to test but unsure how to test?