Refactoring code to reduce level of nesting (Project 1)

[philliparaujo]

Description

The chat.js file has a function openChat that has many levels of nesting due to asynchronous functions and API calls. This PR reduces a specific instance of this nesting, which starts at the api.get('chats/${roomId}') call, by having earlier code return early and remove the need for an else statement.

[philliparaujo]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Originally posted by @sonarcloud[bot] in CMU-313/NodeBB#461 (comment)

[philliparaujo]

Pull Request Test Coverage Report for Build 10694364476

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 82.671%

---

Totals
Change from base Build 10607818019:	0.0%
Covered Lines:	22323
Relevant Lines:	25582

---

💛 - Coveralls

Originally posted by @coveralls in CMU-313/NodeBB#461 (comment)

[coveralls]

Pull Request Test Coverage Report for Build 10985536556

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 7 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.03%) to 82.671%

---

Files with Coverage Reduction	New Missed Lines	%
src/groups/join.js	1	92.05%
src/user/reset.js	3	87.5%
src/user/approval.js	3	87.61%

Totals
Change from base Build 10985395347:	-0.03%
Covered Lines:	22323
Relevant Lines:	25582

---

💛 - Coveralls